Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll transactions (Source) are not committed #56

Closed
ivanyu opened this issue Oct 5, 2020 · 0 comments · Fixed by #57
Closed

Poll transactions (Source) are not committed #56

ivanyu opened this issue Oct 5, 2020 · 0 comments · Fixed by #57

Comments

@ivanyu
Copy link
Contributor

ivanyu commented Oct 5, 2020

In 29581b3, we disabled autocommit for DB connections.

In Sink transactions are explicitly committed and it causes any trouble.

However, in Source, where transactions are read-only, it effectively creates very long running transactions, which is generally a bad idea. Also it causes different problems like #54.

Committing periodically (e.g. in poll()) is a good idea.

ivanyu added a commit that referenced this issue Oct 5, 2020
#56

To prevent long-running read-only transactions, this makes commit when an iteration of `JdbcSourceTask.poll()` finishes.
ivanyu added a commit that referenced this issue Oct 5, 2020
#56

To prevent long-running read-only transactions, this makes commit when an iteration of `JdbcSourceTask.poll()` finishes.
ivanyu added a commit that referenced this issue Oct 5, 2020
To prevent long-running read-only transactions, this makes commit when an iteration of `JdbcSourceTask.poll()` finishes. See #56 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant