Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change log level to debug when reloading #207

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jeqo
Copy link
Contributor

@jeqo jeqo commented Oct 12, 2024

This reloading could happen many times without being actionable and adding noise to the logs.
There is already an info logging when there are changes on reloading:

@jeqo jeqo marked this pull request as ready for review October 12, 2024 17:21
@jeqo jeqo requested review from a team as code owners October 12, 2024 17:21
@jeqo jeqo force-pushed the jeqo/debug-reloading branch from 764a96a to 680cfd9 Compare October 15, 2024 06:10
@jeqo jeqo requested a review from biggusdonzus October 15, 2024 06:56
This reloading could happen many times without being actionable and
adding noise to the logs.
There is already an info logging when there are changes on reloading.
@jeqo jeqo force-pushed the jeqo/debug-reloading branch from 680cfd9 to 383d4e7 Compare October 16, 2024 11:54
@giuseppelillo giuseppelillo merged commit 6dabd23 into main Oct 16, 2024
4 checks passed
@giuseppelillo giuseppelillo deleted the jeqo/debug-reloading branch October 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants