minor webui enhancements #4203
minor webui enhancements #4203
Conversation
|
Thanks. CSS is a weird thing across different browsers. |
I used Chrome for testing. |
|
Please use also Firefox, Safari and Edge. These are main browsers used. |
I dont have a mac could I use an iPad (should also work since it uses webkit right?) |
|
Test on as many as you can. |
|
Now i have tested it on the Windows, Android, and iPadOS versions of Chrome, Firefox, and Edge, as well as on Safari on iPadOS and the WLED Android app |
wled00/data/settings_pin.htm
Outdated
| @@ -11,11 +11,20 @@ | |||
| <style> | |||
| @import url("style.css"); | |||
| </style> | |||
| <script> | |||
| function checkNum(o) { | |||
| const specialkeys = ["Backspace", "Tab", "Enter", "Shift", "Control", "Alt", "Pause", "CapsLock", "Escape", "Space", "PageUp", "PageDown", "End", "Home", "ArrowLeft", "ArrowUp", "ArrowRight", "ArrowDown", "Insert", "Delete"]; | |||
There was a problem hiding this comment.
what does this line do and is it necessary or more of a best practice? it adds quite a lot of code...
There was a problem hiding this comment.
I do not like but at the same time I do not like it when browser joins two words with different style. There has to be a better solution than adding a bunch of into code as it increases flash use.
I also don't see it necessary to add onKeyDown event handling for pin code.
|
I removed the This is the best solution I could find, but it's not perfect
|
|
Much better! 😄 |
wled00/data/style.css
Outdated
| @@ -44,6 +44,9 @@ button.sml { | |||
| min-width: 40px; | |||
| margin: 0 0 0 10px; | |||
| } | |||
| span:before, b:before, b:after, i:after{ | |||
| content: "\00A0"; | |||
There was a problem hiding this comment.
Where exactly were the spaces missing?
I found a problem with the minifyer that was removing spaces. I fixed it with #4267, so this may not be necessary anymore.
There was a problem hiding this comment.
This is currently an issue with the minifyer. This will be fixed with PR #4267.
Changes:
Added a black border around the white color quick-select in light mode.
Adjusted spacing between "Add segment" and "Reset segments" on 1440p screens (see images).
Fixed disappearing spaces after building by adding .Disabled letter input in the PIN field.
Expanded preset content to 100% width (see images).
Fixed font size in "Effect mode" label to match the other labels. And the margin between the labels ans the content
Before:
After:
Before:
After:
