Add WebSocket support (ws) #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
library/helpers/getMaxWsMsgSize.ts
Outdated
|
|
||
| export function getMaxWsMsgSize() { | ||
| if (process.env.AIKIDO_MAX_WS_MSG_SIZE_MB) { | ||
| const parsed = parseInt(process.env.AIKIDO_MAX_WS_MSG_SIZE_MB, 10); |
There was a problem hiding this comment.
let's reuse
| return; | ||
| } | ||
| } catch (e) { | ||
| // Ignore |
There was a problem hiding this comment.
this is dangerous, lets log at least
| } // Handle ArrayBuffer or Buffer | ||
| else if (Buffer.isBuffer(data) || data instanceof ArrayBuffer) { | ||
| const decoder = new TextDecoder("utf-8", { | ||
| fatal: true, |
There was a problem hiding this comment.
can you comment what this means?
|
|
||
| const result = shouldRateLimitRequest(context, agent); | ||
| if (result.block) { | ||
| let message = "You are rate limited by Aikido firewall."; |
There was a problem hiding this comment.
let's remove this for now
| "WebSocket message size exceeded the maximum allowed size. Use AIKIDO_MAX_BODY_SIZE_MB to increase the limit." | ||
| ); | ||
| // Closing does not prevent the regular onMessage event from firing | ||
| socket.terminate(); |
There was a problem hiding this comment.
should we close it?
library/sources/ws/parseWSData.ts
Outdated
| return Array.isArray(data) && data.every((d) => Buffer.isBuffer(d)); | ||
| } | ||
|
|
||
| function checkWsDataSize(data: WsData) { |
There was a problem hiding this comment.
naming suggestion-: isMessageDataTooLarge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws: https://github.com/websockets/ws/blob/master/doc/ws.md