fix: require lts 16 due to openssl changes and webpack4 dep via vuepress #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
53c08da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3738399.documentation-7tp.pages.dev |
| Branch Preview URL: | https://fix-node-pin.documentation-7tp.pages.dev |
ivanlei
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Verified manually -- https://gist.github.com/ivanlei/147561b7051aef2c995429644506ca14
I did need to:
$ nvm install v16.19.1
$ npm install -g yarn
warner
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Feb 22, 2023
The documentation repo recently started requiring Node 16.x (Agoric/documentation#780), but the agoric-sdk CI was still using 14.x . This changes the CI to use the newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the node pin on 16, in both yarn and .node-version. Vuepress depends on webpack4, which is incompatible with stock node 18 without arg modifications. Also performed a driveby update of deprecated github actions versions.
closes: #776