Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes some documentation tasks #41

Merged
merged 15 commits into from
Nov 2, 2019
Merged

Completes some documentation tasks #41

merged 15 commits into from
Nov 2, 2019

Conversation

dominiquejane
Copy link
Contributor

@dominiquejane dominiquejane commented Oct 31, 2019 •
edited
Loading

Completes some tasks in #32

  • Update so CTA goes to Getting Started
  • Pull out 'Gotchas' from ERTP guide and put into own sections
  • Clarify descriptions in Payments and Purse API
  • Adds ContractHost Guide
  • Adds ContractHost API -> incomplete: still have questions/comments (see red text)

Closes #47

@dominiquejane dominiquejane changed the title Doc tasks dom Completes some documentation tasks Oct 31, 2019
barbaraliau
barbaraliau reviewed Nov 1, 2019
View reviewed changes
main/ertp/guide/gotchas.md Outdated Show resolved Hide resolved
main/ertp/guide/gotchas.md Outdated Show resolved Hide resolved
main/.vuepress/config.js Outdated Show resolved Hide resolved
main/ertp/api/contract-hosts.md Outdated Show resolved Hide resolved
dominiquejane
dominiquejane commented Nov 1, 2019
View reviewed changes
Copy link
Contributor Author

@dominiquejane dominiquejane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a couple things in the contractHosts guide and api that need to be addressed and then this should be good for merge.

main/ertp/api/contract-hosts.md Outdated Show resolved Hide resolved
main/ertp/api/contract-hosts.md Outdated Show resolved Hide resolved
main/ertp/guide/contract-hosts.md Outdated Show resolved Hide resolved
@barbaraliau barbaraliau merged commit 1de395a into master Nov 2, 2019
@barbaraliau barbaraliau deleted the doc-tasks--dom branch November 2, 2019 03:04
@dckc dckc mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert left review comments

@barbaraliau barbaraliau barbaraliau left review comments

@katelynsills katelynsills katelynsills left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undeclared module in assay.makeUnits doc
4 participants
@dominiquejane @katelynsills @barbaraliau @Chris-Hibbert