Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ERTP diagram with class diagram (WIP) #1140

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Jul 3, 2024

  • new diagrams
  • edit .md files to include them

Copy link

cloudflare-workers-and-pages bot commented Jul 3, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab960b0
Status: ✅  Deploy successful!
Preview URL: https://99207438.documentation-7tp.pages.dev
Branch Preview URL: https://dc-ertp-classdiagram.documentation-7tp.pages.dev

View logs

Copy link

github-actions bot commented Jul 3, 2024

Cloudflare deployment logs are available here

@amessbee
Copy link
Contributor

amessbee commented Jul 26, 2024

@dckc any specific thing needed that I can work on to pull it out of draft? Personally, I believe there is some clutter in the new diagram. In particular, some of connections are crossing each other that need not do so. If you agree, I can spend some time to draw one with minimum possible crossings, otherwise, let us merge this.

@dckc
Copy link
Member Author

dckc commented Jul 26, 2024

This only has the diagrams. It doesn't change any of the .md files to include them. If you'd like to do that, that would be great.

As to crossings... let's do that in a follow-on PR.

@amessbee
Copy link
Contributor

@dckc have a look: ERTP page in Learn. Does it work?

@dckc dckc marked this pull request as ready for review July 31, 2024 13:35
@dckc
Copy link
Member Author

dckc commented Jul 31, 2024

Yes, this addresses linking the diagrams.

It presents the most complex one first, unfortunately. But we can deal with that in a later edit...

I see lots of stuff I want to change on that page:

  • get rid of quatloos
  • cite thee existing section on ocaps... actually: either drop it or explain how it relates
  • ... and so on

@amessbee
Copy link
Contributor

amessbee commented Aug 1, 2024

Yes, this addresses linking the diagrams.

It presents the most complex one first, unfortunately. But we can deal with that in a later edit...

I see lots of stuff I want to change on that page:

  • get rid of quatloos
  • cite thee existing section on ocaps... actually: either drop it or explain how it relates
  • ... and so on

Created an issue #1165 - let us address them in a fresh PR?

@amessbee amessbee merged commit ab960b0 into main Aug 1, 2024
5 checks passed
@amessbee amessbee deleted the dc-ertp-classdiagram branch August 1, 2024 07:17
@dckc dckc mentioned this pull request Aug 5, 2024
amessbee added a commit that referenced this pull request Aug 6, 2024
Revert "Fix dapp tutorial intro" accidental changes to #1140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants