-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace ERTP diagram with class diagram (WIP) #1140
Conversation
dckc
commented
Jul 3, 2024
•
edited
Loading
edited
- new diagrams
- edit .md files to include them
Deploying documentation with Cloudflare Pages
|
Cloudflare deployment logs are available here |
@dckc any specific thing needed that I can work on to pull it out of draft? Personally, I believe there is some clutter in the new diagram. In particular, some of connections are crossing each other that need not do so. If you agree, I can spend some time to draw one with minimum possible crossings, otherwise, let us merge this. |
This only has the diagrams. It doesn't change any of the .md files to include them. If you'd like to do that, that would be great. As to crossings... let's do that in a follow-on PR. |
@dckc have a look: ERTP page in Learn. Does it work? |
Yes, this addresses linking the diagrams. It presents the most complex one first, unfortunately. But we can deal with that in a later edit... I see lots of stuff I want to change on that page:
|
Created an issue #1165 - let us address them in a fresh PR? |
Revert "Fix dapp tutorial intro" accidental changes to #1140