This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
chore: use wallet-connection component #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
commented
Dec 10, 2021
| @@ -60,6 +62,7 @@ | |||
| "eslint-plugin-prettier": "^3.1.4", | |||
| "eslint-plugin-react": "^7.21.4", | |||
| "eslint-plugin-react-hooks": "^4.1.2", | |||
| "lit": "^2.0.2", | |||
There was a problem hiding this comment.
I'm not sure why it doesn't build without explicitly adding lit as a dependency. I would think it would get it transitively through @agoric/wallet-connection
samsiegart
force-pushed
the
wallet-connection
branch
from
06915b3 to
c8d290b
Compare
michaelfig
approved these changes
Dec 11, 2021
ui/public/conf/defaults.js
Outdated
| @@ -1,13 +1,13 @@ | |||
| // GENERATED FROM /Users/katesills/code/dapp-fungible-faucet/api/deploy.js | |||
There was a problem hiding this comment.
I usually don't check in changes to this files unless the structure actually changes. YMMV.
| @@ -1,5 +1,5 @@ | |||
| // GENERATED FROM /Users/katesills/code/dapp-fungible-faucet/contract/deploy.js | |||
| // GENERATED FROM /home/samsiegart/dapp-fungible-faucet/contract/deploy.js | |||
samsiegart
force-pushed
the
wallet-connection
branch
from
c8d290b to
3925f63
Compare
samsiegart
force-pushed
the
wallet-connection
branch
from
3925f63 to
b0383d2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make this a bit more idiomatic since it's the default dapp template