Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

fix: resolve timer service before instantiating contract #51

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix: resolve timer service before instantiating contract #51

merged 1 commit into from
Mar 29, 2022

Conversation

samsiegart
Copy link
Contributor

fixes: #50

@samsiegart samsiegart mentioned this pull request Mar 23, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

🚀 Deployed on https://62428d37a3b35f7efe11d86b--agoric-dapp-card-store.netlify.app

@samsiegart samsiegart requested a review from michaelfig March 29, 2022 04:46
@samsiegart
Copy link
Contributor Author

@michaelfig Does it make sense to merge this now to get a fix, then we can fix the promise issue in the chain eventually?

@samsiegart samsiegart mentioned this pull request Mar 29, 2022
Closed
michaelfig
michaelfig approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to be defensive, so I'm in favour of merging this PR.

@samsiegart samsiegart merged commit 2bb5ffb into main Mar 29, 2022
@samsiegart samsiegart deleted the fix-bid-invitation branch March 29, 2022 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Bid On A Card
2 participants
@samsiegart @michaelfig