Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swaparoo failed to deploy due to missing config.options.swaparooCommittee #25

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Mar 19, 2024

symptoms were: no swaparoo in published.agoricNames.instance.

Diagnosis:

agd-1  | 2024-03-19T21:48:56.868Z SwingSet: vat: v1: CORE_EVAL failed: (TypeError#3)
agd-1  | 2024-03-19T21:48:56.868Z SwingSet: vat: v1: TypeError#3: startMyCommittee: cannot coerce undefined to object
agd-1  | 2024-03-19T21:48:56.868Z SwingSet: vat: v1: TypeError: startMyCommittee: cannot coerce undefined to object
agd-1  |  at startMyCommittee (#9254:290)
agd-1  |  at startMyCommittee (#9254:277)
agd-1  |  at main (#9254:475)
agd-1  |  at ()

treatment: supply swaparooCommittee options using a new rollup plugin

@dckc dckc requested a review from LuqiPan March 19, 2024 22:30
@dckc
Copy link
Member Author

dckc commented Mar 19, 2024

Here's hoping we can use the e2e-tools.js to test contract functionality in end-to-end mode.

meanwhile... the curl test that looks for swaparoo was good enough to find this one.

Copy link
Collaborator

@LuqiPan LuqiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dckc dckc merged commit 5d800a0 into main Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants