Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup dapp CI config #9947

Merged
merged 4 commits into from
Aug 22, 2024
Merged

fixup dapp CI config #9947

merged 4 commits into from
Aug 22, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Aug 22, 2024

incidental

Description

documentation CI is failing since Agoric/documentation#912

This fixes it

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f70e09
Status: ✅  Deploy successful!
Preview URL: https://58268ba1.agoric-sdk.pages.dev
Branch Preview URL: https://ta-ci-fixup.agoric-sdk.pages.dev

View logs

@turadg turadg requested review from kriskowal and michaelfig August 22, 2024 19:48
@turadg turadg marked this pull request as ready for review August 22, 2024 19:48
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Aug 22, 2024
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just learning about yarn link ../agoric-sdk --all --relative; willing to help give it a try.

- name: point dapp to agoric-SDK HEAD
# This assumes the dapp uses Yarn 4 and its other deps are compatible
# with the versions in the agoric-sdk packages.
run: yarn link ../agoric-sdk --all --relative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting.

@mergify mergify bot merged commit 5b61dc2 into master Aug 22, 2024
100 checks passed
@mergify mergify bot deleted the ta/ci-fixup branch August 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants