chore: Resolve Array.forEach lint warnings #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siarhei-agoric
commented
Jul 11, 2024
gibson042
approved these changes
Jul 11, 2024
siarhei-agoric
force-pushed
the
sliakh-9632-fix_lint
branch
from
c7687e8 to
bb2ce5e
Compare
Deploying agoric-sdk with
|
| Latest commit: |
363f83f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19820dbc.agoric-sdk.pages.dev |
| Branch Preview URL: | https://sliakh-9632-fix-lint.agoric-sdk.pages.dev |
turadg
approved these changes
Jul 11, 2024
toliaqat
approved these changes
Jul 11, 2024
gibson042
reviewed
Jul 11, 2024
gibson042
reviewed
Jul 11, 2024
gibson042
reviewed
Jul 12, 2024
siarhei-agoric
added
the
automerge:rebase
Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: Richard Gibson <[email protected]>
gibson042
force-pushed
the
sliakh-9632-fix_lint
branch
from
74ad576 to
363f83f
Compare
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9632
Description
Replaced
Array.forEach();calls withfor ( x of y ) { };loops.Security Considerations
Assume that Array.forEach() calls are equivalent to
for ( x of y ) { };in all cases.Scaling Considerations
No significant difference expected.
Documentation Considerations
N/A
Testing Considerations
No new tests required. Local tests passed, including lint (specific to this PR).
Upgrade Considerations
The change preserves the behavior, thus there are no upgrade concerns.