single Prettier config #9664
Merged
single Prettier config #9664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
approved these changes
Jul 8, 2024
|
What about Endo? Attn @kriskowal |
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- seem like it was missed in #9664, but not caught since this job runs after merges to master
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- seem like it was missed in #9664, but not caught since this job runs after merges to master
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- seem like it was missed in #9664, but not caught since this job runs after merges to master
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- seem like it was missed in #9664, but not caught since this job runs after merges to master
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- seem like it was missed in #9664, but not caught since this job runs after merges to master
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- seem like it was missed in #9664, but not caught since this job runs after merges to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
In a recent multichain-testing PR the Shell script format changed without any CI errors, suggesting it wasn't under the
lint:formatcheck. The reason is that the directory wasn't included in the rootlint:formatpaths. This adds them there and the rootformatcommand.It also removes the Prettier config within the package so that the repo's one at root is used. Code formatting is a repo-level concern. Packages need only depend on 'prettier' when they have a runtime dependency.
This also bumps prettier to latest for good measure.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
lint:formattested locally to fail if I force an error in a .sh, and repaired withformat.Upgrade Considerations
none