6000 remove zoe floating promises #9458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
Zoe
Deploying agoric-sdk with
|
| Latest commit: |
87268ad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f74218b7.agoric-sdk.pages.dev |
| Branch Preview URL: | https://6000-no-zoe-floating-promise.agoric-sdk.pages.dev |
|
@turadg: please check out my revisions to the tests, particularly |
turadg
approved these changes
Jun 7, 2024
| @@ -42,7 +41,7 @@ const build = async (log, zoe, issuers, payments, installations) => { | |||
| }); | |||
| const alicePayments = { Asset: moolaPayment }; | |||
|
|
|||
| logCounter(log, publicFacet); | |||
| await logCounter(log, publicFacet); | |||
There was a problem hiding this comment.
probably ok if these stayed void but good to have the confident now of what the order is
| @@ -732,15 +737,20 @@ test('quoteWhen', async t => { | |||
|
|
|||
| /** @type {PriceQuote | undefined} */ | |||
| let abovePriceQuote; | |||
| t.notThrowsAsync(quoteWhenGTE.then(result => (abovePriceQuote = result))); | |||
| const results = []; | |||
There was a problem hiding this comment.
consider commenting here why this array is necessary
Chris-Hibbert
force-pushed
the
6000-no-zoe-floating-promises
branch
from
c012f04 to
3ffdfe8
Compare
Chris-Hibbert
force-pushed
the
6000-no-zoe-floating-promises
branch
from
3ffdfe8 to
87268ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6000
Description
Resolve remaining floating promises in Zoe
Security Considerations
Zoe's correct functioning is crucial to the chain. I determined that it was correct to not further handle any of these promises.
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
N/A
Upgrade Considerations
No impact, because no behavioral changes.