6000 reduce floating promises #9416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e332a3a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://45e5b670.agoric-sdk.pages.dev |
| Branch Preview URL: | https://6000-reduce-floating-promise.agoric-sdk.pages.dev |
Chris-Hibbert
requested changes
May 28, 2024
| @@ -78,7 +77,7 @@ test('tick does not flush by default', async t => { | |||
| const handler = Far('handler', { | |||
| wake: scheduled => { | |||
| woken = scheduled; | |||
| stallLots().then(() => (later = true)); | |||
| void stallLots().then(() => (later = true)); | |||
There was a problem hiding this comment.
I think these should be await. stallLots() is just a delay. it does nothing with void.
There was a problem hiding this comment.
Since I punted some Zoe already I just punted the rest of Zoe to https://github.com/Agoric/agoric-sdk/compare/6000-no-zoe-floating-promises
(I lost one of my commits, unfortunately, but that has the Zoe one from this branch.)
turadg
force-pushed
the
6000-reduce-floating-promises
branch
from
8c54d65 to
98614ce
Compare
Chris-Hibbert
approved these changes
May 28, 2024
turadg
force-pushed
the
6000-reduce-floating-promises
branch
from
98614ce to
e332a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6000
Description
I keep seeing these warnings and they're distracting. This burns down almost all of them. What's left are a handful in Zoe that may be best for @Chris-Hibbert to tackle directly.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
Some of these change the test. Reviewers should be confident in the changes.
Upgrade Considerations
None of these should change the end-user API. Some may fix bugs.