proto bumps for MsgCancelUnbondingDelegation #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
94334b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7f411fc9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-proto-bumps.agoric-sdk.pages.dev |
JimLarson
approved these changes
Apr 24, 2024
Comment on lines
+19
to
+22
| # clean up what we don't need | ||
| chmod -R u+w proto | ||
| rm -rf proto/cosmos/app | ||
| rm -rf proto/cosmos/orm |
There was a problem hiding this comment.
There's a lot of stuff in there that you probably don't need, and you might stub your toe a few times when needs change, but it's your call.
packages/cosmic-proto/MAINTAINERS.md
Outdated
| @@ -8,7 +8,7 @@ The generated code is determined by the contents of `protos` and the config of ` | |||
|
|
|||
| ## Maintaining protos | |||
|
|
|||
| The `protos` are held in this source tree and updated from `golang/cosmos/proto` during `yarn codegen` by `yarn protos-update`. The `cosmos` protos were sourced from [@protobufjs/cosmos](https://www.npmjs.com/package/@protobufs/cosmos) per [Telescope's instructions](https://github.com/cosmology-tech/telescope?tab=readme-ov-file#add-protobufs). However we don't use that as a dependency of the package because we need a more manual approach to merge with the Golang-managed protos in the repo. | |||
| The `protos` are held in this source tree and updated from `golang/cosmos/proto` during `yarn codegen` by the `update-protos.sh` script. | |||
There was a problem hiding this comment.
This is ambiguous whether yarn codegen invokes update-protos.sh or vice-versa. Make it clear that you call yarn codegen and consider letting folks just read the implementation if they want to see how it works.
I've updated the instructions on the Upgrading the Interchain Stack wiki page.
0xpatrickdev
approved these changes
Apr 24, 2024
| # update proto files in this package | ||
| cp -rf "$COSMOS_SDK"/proto/cosmos proto | ||
| cp -rf "$AG_SDK"/golang/cosmos/third_party/proto . | ||
| cp -rf "$AG_SDK"/golang/cosmos/proto/agoric proto |
There was a problem hiding this comment.
LGTM. Seems this should preserve protos added manually (like /icq/v1) that are not part of /golang/cosmos/third_party/proto
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2024
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> <!-- Most PRs should close a specific Issue. All PRs should at least reference one or more Issues. Edit and/or delete the following lines as appropriate (note: you don't need both `refs` and `closes` for the same one): --> Like #9284, but also adds `ibc` protos from `ibc-go/v6`. Motivated by needing `MsgTransfer` for #9193. closes: #XXXX refs: #9193 ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> ### Security Considerations <!-- Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls? --> ### Scaling Considerations <!-- Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated? --> ### Documentation Considerations <!-- Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users? --> ### Testing Considerations <!-- Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet? --> Added `ibc` to the snapshot tests for this package. ### Upgrade Considerations <!-- What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed? --> Unlike the `COSMOS_SDK` variable in `update-protos.sh`, `IBC_GO` contains a version (v6) in the path which may require someone to update the script when the `cosmos/ibc-go` version is bumped. If someone wants to suggest a different approach that uses regex, that's more than welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the proto updating mechanism more robust, getting the latest definitions used in the SDK branch. PTAL @JimLarson
Also adopts the new
MsgCancelUnbondingDelegationthat is available. PTAL @0xpatrickdevSecurity Considerations
none
Scaling Considerations
none
Documentation Considerations
More automated now
Testing Considerations
Manual
Upgrade Considerations
Improves sync of cosmic-proto package with cosmic-swingset