Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pick up cosmos-sdk with more abci flag tests #9263

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

JimLarson
Copy link
Contributor

closes: #9224

Description

Pick up new version of cosmos-sdk that includes more tests and documentation for the abci client type setting.

Security Considerations

N/A

Scaling Considerations

If the setting is used to revert to the "local" client, query throughput drops dramatically.

Documentation Considerations

Docs added to TOML template, but this is an expert-level switch and no one should use it without a good understanding of the impact.

Testing Considerations

N/A

Upgrade Considerations

N/A

@JimLarson JimLarson added enhancement New feature or request agoric-cosmos labels Apr 19, 2024
@JimLarson JimLarson requested a review from gibson042 April 19, 2024 17:14
@JimLarson JimLarson self-assigned this Apr 19, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 19, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d9a63d
Status: ✅  Deploy successful!
Preview URL: https://4be3c2b9.agoric-sdk.pages.dev
Branch Preview URL: https://9224-abci-flag-tests.agoric-sdk.pages.dev

View logs

@JimLarson JimLarson added the automerge:rebase Automatically rebase updates, then merge label Apr 19, 2024
@JimLarson JimLarson force-pushed the 9224-abci-flag-tests branch from f90a214 to 0d9a63d Compare April 19, 2024 18:12
@mergify mergify bot merged commit 947973c into master Apr 19, 2024
67 checks passed
@mergify mergify bot deleted the 9224-abci-flag-tests branch April 19, 2024 18:46
gibson042 pushed a commit that referenced this pull request Apr 19, 2024
closes: #9224

## Description

Pick up new version of cosmos-sdk that includes more tests and
documentation for the abci client type setting.

### Security Considerations

N/A

### Scaling Considerations

If the setting is used to revert to the "local" client, query throughput
drops dramatically.

### Documentation Considerations

Docs added to TOML template, but this is an expert-level switch and no
one should use it without a good understanding of the impact.

### Testing Considerations

N/A

### Upgrade Considerations

N/A
gibson042 added a commit that referenced this pull request Apr 19, 2024
## Description

Includes commits from the following PRs:
* #9030 (partial cherry-pick; refactors go.mod)
* #9251
* #9263

Constructed using the following `git rebase -i HEAD` todo list:
```
# pull request #9030 branch mfig-ibc-revamp
## Replace this commit with just its refactoring of golang/cosmos/go.mod
## and subsequent `go mod tidy`.
edit fff392b build(cosmos): add `ibc-go` fork and `go mod tidy`
exec git commit --amend --reset-author -m 'build(cosmos): Refactor go.mod to match master'

# pull request #9251 branch 9224-u15-changes
label base-9224-u15-changes
## Resolve conflict using `go mod tidy`.
pick 548e758 fix: various fixes and features for u15
label 9224-u15-changes
reset base-9224-u15-changes
merge -C c1ec5f1 9224-u15-changes # fix: various fixes and features for u15 (#9251)

# pull request #9263 branch 9224-abci-flag-tests
label base-9224-abci-flag-tests
pick 0d9a63d test: pick up cosmos-sdk with more abci flag tests
label 9224-abci-flag-tests
reset base-9224-abci-flag-tests
merge -C 947973c 9224-abci-flag-tests # test: pick up cosmos-sdk with more abci flag tests (#9263)
```

### Security Considerations

None in particular.

### Scaling Considerations

This brings in the ability to switch between "local" and "committing"
query client behavior.

### Documentation Considerations

Adopted by reference.

### Testing Considerations

No additions.

### Upgrade Considerations

To be included in agoric-upgrade-15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos automerge:rebase Automatically rebase updates, then merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature flag for use of committing client in cometbft
2 participants