localchain queryMany and bankManager #9086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Mar 14, 2024
| * Deposit a payment into the bank purse that matches the alleged brand. | ||
| * This is safe, since even if the payment lies about its brand, ERTP will | ||
| * reject spoofed payment objects when depositing into a purse. | ||
| * |
There was a problem hiding this comment.
I don't expect this change for this PR, but I think we should have a solid story around ERTP payment recovery sets and how to use them to prevent orphaned payments if the deposit or getAllegedBrand methods get stuck.
turadg
force-pushed
the
ta/localchain-queryMany
branch
from
af2a2cb to
5b789c5
Compare
mergify bot
added a commit
that referenced
this pull request
May 9, 2024
follow-up to: #9086 ## Description In preparation for addressing excess authority (#9354): - To allow for state upgrade, rather than introducing the complexity of the power store in this initial version, reserve one property for future use - Require all localChain powers at intialization, which eliminates the need for the admin.setPower method. ### Security / Documentation Considerations n/a ### Scaling Considerations small constant factor change: removing the indirection thru the power store removes 1 syscall per access ### Testing Considerations existing tests suffice ### Upgrade Considerations code is not yet released / deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #8624, localchain changes that don't depend on vtransfer
Security Considerations
Creates a PowerStore map that is mutable
Scaling Considerations
Storing the PowerStore.
Documentation Considerations
Some new APIs. No separate docs exist yet to update.
Testing Considerations
queryManyis covered in tests.Upgrade Considerations
Not yet deployed