Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove restart-vats from a3p #9004

Merged
merged 2 commits into from
Feb 27, 2024
Merged

remove restart-vats from a3p #9004

merged 2 commits into from
Feb 27, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 27, 2024

Description

#8907 introduced generate-a3p-submission.sh which is now being used in master for b:localchain. The value of an additional "example" core-eval with restarts-vats is not worth the cost to development time and confusion: #8911 (comment)

So this removes that proposal and instead links to 8907 to provide the example. It's currently redundant with the b:localchain but eventually that will go on chain and not be part of master.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

Revised

Testing Considerations

We want acceptance tests eventually, but they may look very different.

Upgrade Considerations

n/a

@turadg turadg requested review from mhofman and michaelfig February 27, 2024 22:37
@turadg turadg mentioned this pull request Feb 27, 2024
a3p-integration/README.md Show resolved Hide resolved
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Feb 27, 2024
@mergify mergify bot merged commit 18d561f into master Feb 27, 2024
74 checks passed
@mergify mergify bot deleted the ta/remove-restart-vats branch February 27, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants