8453 release2 zoe #8802
Merged
8453 release2 zoe #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
turadg
approved these changes
Jan 23, 2024
mhofman
force-pushed
the
8453-release2-Zoe
branch
from
fadbaf7
to
c33d3c7
Compare
mhofman
changed the base branch from
tmp-upgrade-15
to
mhofman/fix-up-upgrade-14
mhofman
force-pushed
the
mhofman/fix-up-upgrade-14
branch
from
3b48d81
to
ceffbcd
Compare
use watchPromise() to wait for contract finish; This repairs new contracts, but doesn't help existing contracts.
There was a bug in the part of the test that was attempting to run a bunch of scenarios across the upgrade. Rather than resuming each run after the upgrade, it was running the whole scenario from scratch after the upgrade.
mhofman
force-pushed
the
8453-release2-Zoe
branch
from
c33d3c7
to
167b884
Compare
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8453
Description
Add to the release branch the code to allow Zoe to survive upgrade by using watchedPromises. (#8453)
This is a repeat of #8792 to recreate the tmp-upgrade-15 branch without merging PRs.
These are the same commits as on master.
Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
See #8453
Upgrade Considerations
see above.