Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: restore core proposal in upgrade test #8754

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 15, 2024

refs: #8635

Description

As noted in https://github.com/Agoric/agoric-sdk/pull/8635/files#r1452459188, the new a3p based tests no longer simulate a core proposal of installing the network components. With Agoric/agoric-3-proposals#63 implemented, this PR restores that test.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Restores removed test

Upgrade Considerations

This changing test code of upgrade related features

@mhofman mhofman added the force:integration Force integration tests to run on PR label Jan 15, 2024
@mhofman mhofman requested review from turadg and michaelfig January 15, 2024 14:44
@mhofman mhofman force-pushed the mhofman/update-a3p branch from bcc7a8e to 37952e6 Compare January 15, 2024 15:22
@mhofman mhofman force-pushed the mhofman/update-a3p branch from 37952e6 to dd296e9 Compare January 15, 2024 16:21
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mhofman mhofman added automerge:no-update (expert!) Automatically merge without updates and removed force:integration Force integration tests to run on PR labels Jan 15, 2024
@mergify mergify bot merged commit 627b56b into master Jan 15, 2024
77 checks passed
@mergify mergify bot deleted the mhofman/update-a3p branch January 15, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants