Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(base-zone,store): prepare for migration to endo repo #8749

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

erights
Copy link
Member

@erights erights commented Jan 14, 2024

closes: #XXXX
refs: #8745

Description

By removing dependencies from this pair to anything else in agoric-sdk, we prepare to move this pair of packages from the agoric-sdk repo to the endo repo.

From internal discussions, it is clear that the agoric-sdk repository and the endo repository will remain separate at least for the immediate future, and possibly forever. However, for the current boundary between the two to make sense, there remain two misplaced packages: @agoric/base-zone and @agoric/store. This PR just prepares them to make the migration, but does nothing else.

Additional motivation (that finally pushed me to start this) is @dckc's comment at #8745 (comment) . Once prepare-revocable.js is refactored to depend on zones, it will no longer be limited to durable objects, but can be used with any zone. At that point, it should live in the endo repo. (The rest of #8745 , which is about ownables, should remain in agoric-sdk because it uses zoe concepts.)

Security Considerations

For this PR itself, none. For the migration it prepared for, likely none as well, but we'll be explicit about that then.

Scaling Considerations

For this PR itself, none. For the migration it prepared for, likely none as well, but we'll be explicit about that then.

Documentation Considerations

For this PR itself, mostly none. For the migration it prepared for, likely none as well, but we'll be explicit about that then.

I did add a note to the README of both packages explaining that these will be migrated to the endo repo.

Testing Considerations

For this PR itself, none. For the migration it prepared for, likely none as well, but we'll be explicit about that then.

Upgrade Considerations

For this PR itself, none. For the migration it prepared for, likely none as well, but we'll be explicit about that then.

@ivanlei , I added you as a reviewer to judge when this PR could be merged without being too disruptive.

@erights erights force-pushed the markm-prepare-store-base-zone-4endo branch from 29ae717 to 0d5f3b7 Compare January 16, 2024 19:49
@erights erights requested a review from FUDCo January 16, 2024 19:50
@erights erights force-pushed the markm-prepare-store-base-zone-4endo branch 2 times, most recently from 9e2cc3b to 0f7317a Compare January 18, 2024 04:56
@erights erights force-pushed the markm-prepare-store-base-zone-4endo branch from 0f7317a to 58ab8fa Compare January 21, 2024 05:16
@erights erights requested a review from ivanlei January 21, 2024 05:25
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepare for migration to endo repo

suggested clarification: remove dependencies on @agoric/* modules

I've been struggling to understand which end is up here. If I'm reading this
right, that's the gist of it.

Looks plausible.

But without a clear sense of how this gets released / deployed,
I leave it to others to approve.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelfig
Copy link
Member

For release, I understand that these packages will be copied to Endo, then after a new Endo sync, these packages will be updated to be stubs that import the Endo versions.

@erights
Copy link
Member Author

erights commented Jan 26, 2024

prepare for migration to endo repo

suggested clarification: remove dependencies on @agoric/* modules

I decided against changing the summary string, because I'd rather summarize the purpose than the mechanism. But I did add this clarification to the beginning of the PR description.

@erights erights force-pushed the markm-prepare-store-base-zone-4endo branch from 58ab8fa to 72cd730 Compare January 26, 2024 19:18
@erights erights added automerge:squash Automatically squash merge and removed automerge:squash Automatically squash merge labels Jan 26, 2024
@erights erights force-pushed the markm-prepare-store-base-zone-4endo branch 2 times, most recently from 89d5214 to efdd4bb Compare January 27, 2024 11:38
@erights erights force-pushed the markm-prepare-store-base-zone-4endo branch from efdd4bb to 198578d Compare January 27, 2024 11:46
@erights erights added the automerge:squash Automatically squash merge label Jan 27, 2024
@mergify mergify bot merged commit 7d47297 into master Jan 27, 2024
74 checks passed
@mergify mergify bot deleted the markm-prepare-store-base-zone-4endo branch January 27, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants