test: support for watchedPromises in fakeVirtualSupport #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
approved these changes
Dec 6, 2023
| @@ -348,6 +356,7 @@ export function makeFakeVirtualStuff(options = {}) { | |||
| vom.initializeKindHandleKind(); | |||
| const cm = makeFakeCollectionManager(vrm, fakeStuff, actualOptions); | |||
| const wpm = makeFakeWatchedPromiseManager(vrm, vom, cm, fakeStuff); | |||
| wpm.preparePromiseWatcherTables(); | |||
There was a problem hiding this comment.
I remain suspicious that this call should not be here. However, it is normally done from startVat, which I suppose is always going to be absent from tests using the fake virtual stuff, so providing the call here is certainly a convenience. Just beware that this might come back later to bite us.
Chris-Hibbert
force-pushed
the
8455-fakeVirtual-watchedPromises
branch
from
588d6a1 to
8129d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8488
Description
Make it possible for
convertValToSlot()to handle vals that are promises. This is needed for WatchedPromises, as used in #8488. The issue has also arisen in 8563, in connection with whenables.Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
fixed one existing test. If it should have a test specifically related to watchedPromises, please help me construct one.
Upgrade Considerations
smartWallet upgrade (#8488) depends on watched Promises. Tests don't pass without a fix to fakeVirtual.