refactor cosmos init #8060
Merged
refactor cosmos init #8060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
commented
Jul 18, 2023
michaelfig
reviewed
Jul 18, 2023
JimLarson
suggested changes
Jul 19, 2023
michaelfig
approved these changes
Jul 19, 2023
JimLarson
approved these changes
Jul 20, 2023
Comment on lines
1
to
5
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | ||
| # yarn lockfile v1 | ||
|
|
||
|
|
||
| lastUpdateCheck 1689807326102 |
There was a problem hiding this comment.
Did this file get accidentally included?
| @@ -837,6 +838,7 @@ type cosmosInitAction struct { | |||
| // Name returns the name of the App | |||
| func (app *GaiaApp) Name() string { return app.BaseApp.Name() } | |||
|
|
|||
| // CheckControllerInited exits if the controller initialization state does not match `expected`. | |||
There was a problem hiding this comment.
The godoc tool doesn't parse markdown.
Suggested change
| // CheckControllerInited exits if the controller initialization state does not match `expected`. | |
| // CheckControllerInited exits if the controller initialization state does not match expected. |
There was a problem hiding this comment.
Is that a problem? In general I prefer delimiting code references with backticks even if they don't get parsed as markdown.
mhofman
force-pushed
the
mhofman/refactor-cosmos-init
branch
from
9aa87e3 to
f19ebc8
Compare
mhofman
force-pushed
the
mhofman/refactor-cosmos-init
branch
from
f19ebc8 to
554a110
Compare
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit
Description
In order to support the migrations needed for #8025 #8031, and to implement #6527, we need to extend the cases where the snapshot logic is exercised. This PR simply adds guards where they were previously implicit through usage. It also fixes a potential bootstrap timing issue, where it was performed before the
x/lienmodule was initialized. Finally it makes the timing ofAG_COSMOS_INITmore explicit (no longer lazy on first BlockingSend)Security Considerations
Adds checks regarding assumed init ordering
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
As with most logic straddling between golang and JS, there is little tests beyond the integration tests. This PR is changing little behavior, and what is changes does not have existing unit test coverage.