restore types linting #8058
Merged
restore types linting #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use new EXPERIMENTAL_useProjectService which makes this performant enough to use
fixes a type error inferring from node_modules cjs files
kriskowal
approved these changes
Jul 17, 2023
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env node | |||
| // @ts-nocheck | |||
There was a problem hiding this comment.
I was dismayed by all these @ts-nocheck until I realized that they weren’t previously checked and that you’ve just moved the exclusion from jsconfig.json to individual files, presumably so we can reveal them to the checker individually. Carry on.
There was a problem hiding this comment.
bingo. glad that was apparent enough since I was too lazy to leave a comment explaining
| @@ -36,6 +36,8 @@ module.exports = { | |||
| parser: '@typescript-eslint/parser', | |||
| parserOptions: lintTypes | |||
| ? { | |||
| // this is not yet compatible with eslint lsp so it's conditioned on AGORIC_ESLINT_TYPES | |||
There was a problem hiding this comment.
Recommend “gated”, “contingent on”, or “predicated”.
There was a problem hiding this comment.
all better, though imo not different enough to suffer through the Chain deployment test again.
Merged
mergify bot
added a commit
that referenced
this pull request
Nov 14, 2024
_no issue_ ## Description #8058 made linting with types fast enough to enable again. It's even fast enough now that the splitting doesn't save any time. This gets rid of the `lint-with-types.sh` script that managed the splitting. The CI job now just runs `yarn lint`. Doing that required that each package's `yarn lint` command has types enabled, so it does that too. An upshot is that now running `yarn lint` locally will check no-floating-promises, even though the IDE still doesn't. ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations reduces need to document ### Testing Considerations CI. ~Once it passes, someone will have to update branch protections to remove the split primary/rest requirements.~ When this PR started there wasn't a point to two jobs, but now the second job covers a3p-integration so it's worth keeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5788
refs: #7888
Description
Types linting got very slow so we had to disable it.
typescript-eslint/typescript-eslint#6754 solved a problem in linting plugin whereby it was repeating work.
It worked by operating more like the IDE so I thought it would also help with #4620 , but when I tested in VS Code the ESLint plugin failed. I bet it will get worked out eventually. Meanwhile we can still use this new option for CI runs, restoring our floating-promise warnings and opening the door to error on them.
Security Considerations
Scaling Considerations
Documentation Considerations
Reviewers, it is recommended to review by commit.
Testing Considerations
CI
The two lint jobs each take 5min. (Only 30s of that is setup overhead so they could be combined into one job that takes ~10min, which is still faster than most of the jobs. It might be even faster that than since this new option re-uses projects. But I'll leave that consolidation to another PR since it affects the GH repo "required checks" rules.)