chore(packages): fix default param lint warnings

[toliaqat]

refs: #8032

Description

This PR removes the following lint warnings:

GitHub Actions / lint-rest 
Defaults are not permitted on @param

With the recent update of eslint-plugin-jsdoc, we got a change in their rules to warn about this. This link has detail on why they recommend to not use defaults with @param: https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.README/rules/no-defaults.md

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

[gibson042]

These changes make the JSDoc documentation less useful IMO (requiring one to look in two places to find both a description of a parameter and its default value). I'd rather have a lint rule enforcing consistency than one requiring us to exclude relevant details, but the former doesn't seem to be available so I'm torn about running with this vs. disabling no-defaults. Would anyone else like to weigh in?

[gibson042]

cacheSize isn't even a thing anymore AFAICT, having been removed by #7138.

Suggested change

* @param {number} [options.cacheSize]

[gibson042]

This one should probably stay, unless the function is updated to actually use an ES6 parameter default.

 export const offerTo = async (
   zcf,
   invitation,
   keywordMapping,
   proposal,
   fromSeat,
-  toSeat,
+  toSeat = fromSeat,
   offerArgs,
 ) => {
   if (keywordMapping === undefined) {
     keywordMapping = harden({});
   }
 
-  const definedToSeat = toSeat !== undefined ? toSeat : fromSeat;
-
   const zoe = zcf.getZoeService();
   const mappingReversed = reverse(keywordMapping);
 
   const newKeywords =
     proposal !== undefined
       ? mapKeywords(proposal.give, mappingReversed)
       : harden({});
 
   // the proposal is in the other contract's keywords, but we want to
   // use `proposal.give` to withdraw
   const payments = await withdrawFromSeat(zcf, fromSeat, newKeywords);
 
   // Map to the other contract's keywords
   const paymentsForOtherContract = mapKeywords(payments, keywordMapping);
 
   const userSeatPromise = E(zoe).offer(
     invitation,
     proposal,
     paymentsForOtherContract,
     offerArgs,
   );
 
   const depositedPromiseKit = makePromiseKit();
 
   const doDeposit = async payoutPayments => {
     // after getPayouts(), getFinalAllocation() resolves promptly.
     const amounts = await E(userSeatPromise).getFinalAllocation();
 
     // Map back to the original contract's keywords
     const mappedAmounts = mapKeywords(amounts, mappingReversed);
     const mappedPayments = mapKeywords(payoutPayments, mappingReversed);
-    await depositToSeat(zcf, definedToSeat, mappedAmounts, mappedPayments);
+    await depositToSeat(zcf, toSeat, mappedAmounts, mappedPayments);
     depositedPromiseKit.resolve(mappedAmounts);
   };