remove stakeFactory #7608
Merged
remove stakeFactory #7608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
May 4, 2023
turadg
force-pushed
the
ta/remove-stakeFactory
branch
2 times, most recently
from
45b661f to
f591106
Compare
dckc
reviewed
May 4, 2023
| * @param {Address} addr | ||
| * @param {string} addr |
There was a problem hiding this comment.
@michaelfig note the regression. Seems OK to me considering...
turadg
force-pushed
the
ta/remove-stakeFactory
branch
2 times, most recently
from
a54df39 to
ba65438
Compare
turadg
force-pushed
the
ta/remove-stakeFactory
branch
from
ba65438 to
9cb07e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed #7563 did some disabling of stakeFactory. Since it's not part of the release, I propose that we remove it from the code as did for #7074.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
If/when we want to restore this contract we'll probably want to restore git history. I think we can do that simply by reverting the removal commit. (The conflicts should be minimal.)
Testing Considerations
CI