style(solo): Avoid dropping promises #7580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
May 2, 2023
packages/solo/src/vat-http.js
Outdated
| E(walletAdmin).resolveAttMaker(attMaker); | ||
| }); | ||
|
|
||
| const resolvedAttrMakers = Promise.all([walletP, attMakerP]).then( |
There was a problem hiding this comment.
It's not an AttributeMaker, it's an AttestationMaker. And together, they are const walletInitializedP.
kriskowal
force-pushed
the
kris-6000-solo-dangling-promises
branch
from
99c69fa to
88e5ec3
Compare
kriskowal
force-pushed
the
kris-6000-solo-dangling-promises
branch
from
88e5ec3 to
a95fb3e
Compare
|
Will return to this another time. The problems revealed in CI have been too time-consuming to isolate for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #6000, this sinks the floating promises in the
solopackage.Security Considerations
This should give us greater confidence that errors are observable in the relevant async contexts.
Scaling Considerations
This should not impact scalability.
Documentation Considerations
This should not have user observable effects and should not require documentation.
Testing Considerations
These changes should be adequately covered by the solo integration test in CI but
solois in general not covered by unit tests.