feat(controller): louder UnhandledPromiseRejection log #7547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
commented
Apr 29, 2023
| @@ -75,7 +75,7 @@ function makeConsole(tagOrTagCreator) { | |||
| function unhandledRejectionHandler(e, pr) { | |||
| // Don't trigger sensitive hosts (like AVA). | |||
| pr.catch(() => {}); | |||
| console.error('UnhandledPromiseRejectionWarning:', e); | |||
| console.error('🚨 UnhandledPromiseRejection:', e); | |||
There was a problem hiding this comment.
or maybe 📣 since it's not necessarily a problem.
alternately we can treat all failures as a problem and have an explicit catch for "expected to never happen" or "ignore failure"
kriskowal
approved these changes
May 1, 2023
| @@ -75,7 +75,7 @@ function makeConsole(tagOrTagCreator) { | |||
| function unhandledRejectionHandler(e, pr) { | |||
| // Don't trigger sensitive hosts (like AVA). | |||
| pr.catch(() => {}); | |||
| console.error('UnhandledPromiseRejectionWarning:', e); | |||
| console.error('🚨 UnhandledPromiseRejection:', e); | |||
turadg
force-pushed
the
ta/louder-unhandled
branch
from
5059ad9 to
cd67304
Compare
turadg
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On many occasion debugging the
UnhandledPromiseRejectionWarningstring gets lost in the noise of other logs.It's a pretty serious problem that I think deserves to be called out in the logs. Especially in production. #6000 will help but it still leaves many
void.Looking for three approvals before merge, given how this affects workfow.
Security Considerations
--
Scaling Considerations
--
Documentation Considerations
--
Testing Considerations
--