Multicast http handlers #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR also moves and refactors:
|
warner
approved these changes
Mar 22, 2020
packages/agoric-cli/agoric-wallet-build/static/js/main.873f8d69.chunk.js
Show resolved
Hide resolved
This anticipates support for #748 in the command device.
michaelfig
force-pushed
the
mfig/multicast-http-handlers
branch
from
7a9cd4a to
f50a94b
Compare
|
Sounds good, I'll implement that the next time I need to change the wallet.
…--
Michael FIG
Software Engineer, Agoric
On Mon, Mar 23, 2020, 12:05 AM Brian Warner ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/agoric-cli/agoric-wallet-build/asset-manifest.json
<#752 (comment)>:
> "runtime-main.js": "./static/js/runtime-main.6d19b3b8.js",
"runtime-main.js.map": "./static/js/runtime-main.6d19b3b8.js.map",
"static/js/2.80be0d87.chunk.js": "./static/js/2.80be0d87.chunk.js",
"static/js/2.80be0d87.chunk.js.map": "./static/js/2.80be0d87.chunk.js.map",
"index.html": "./index.html",
- "precache-manifest.8f442f599464d859b54c66608d0d6853.js": "./precache-manifest.8f442f599464d859b54c66608d0d6853.js",
+ "precache-manifest.c6e69f21c2aea8705c2c098601680840.js": "./precache-manifest.c6e69f21c2aea8705c2c098601680840.js",
Could we generate those files during a build step in agoric-cli? (at the
expense of requiring folks run yarn build after making changes to
anything under agoric-wallet-build/)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#752 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPUHG2PGXONIVISI6KGGDRI334BANCNFSM4LQWM4ZQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate endpoints into
/private/*(only accessible from localhost) and public ones.The support in this PR for
sendMulticast(no global broadcast anymore from the HTTP vat) anticipates #748