feat: tweak state-sync logging #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not default to printing out export steps Add logging to restore process
gibson042
approved these changes
Apr 20, 2023
Comment on lines
+541
to
+544
| console.info( | ||
| 'Initiating SwingSet state snapshot at block height', | ||
| blockHeight, | ||
| ); |
There was a problem hiding this comment.
Hmm, should this precede the tmpdir creation?
| @@ -274,7 +274,7 @@ export const main = async ( | |||
| { | |||
| fs, | |||
| pathResolve, | |||
| log: verbose ? console.log : undefined, | |||
| log: verbose ? console.log : null, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #7225
Description
After getting devnet traces, I realized that the restore process could use a few more details.
I also figured out why the snapshot process was unexpectedly verbose.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Verified output manually