collectionManager: refcount remotables in keyShape/valueShape #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
added
SwingSet
|
Two of the new tests are disabled because I haven't been able to figure out how to avoid the "unhandled rejection" error from flunking the test. @gibson042 I could probably use your help figuring out that one. |
|
hrm, something is failing in a packages/vats upgrade test, feels like the refcounts are causing something to get deleted by mistake, will investigate tomorrow |
warner
force-pushed
the
7321-refcount-keyshape-vrefs
branch
3 times, most recently
from
93cb8ae to
b147977
Compare
warner
force-pushed
the
7321-refcount-keyshape-vrefs
branch
from
b147977 to
c260cc8
Compare
FUDCo
approved these changes
Apr 10, 2023
warner
force-pushed
the
6360-schema-cache
branch
from
082f244 to
83155ef
Compare
warner
force-pushed
the
7321-refcount-keyshape-vrefs
branch
4 times, most recently
from
a9b2fad to
db996d0
Compare
The collection schema (keyShape/valueShape) can refer to specific Remotable instances (e.g. Presence, or a durable object), rather than defining a constraint to be a whole category of objects. The collection schema metadata is thus a form of write-once state storage, like a tiny virtual object. Previously, defineKind failed to increment the refcount on the objects' vrefs, so when the collection falls out of memory, the object might be deleted, and then we would be unable to revive the constraint when loading the schema back in later. This changes the code to increment the refcounts of the vrefs in keyShape and valueShape when the collection is created, and decrement them when the collection is deleted. It handles ephemeral Remotables, as well as virtual/durable object Representatives. For durable collections, it also enforces the same `isDurable` check on the schema as it would on keys and values of the collection itself, so you cannot use a `Far()` or a merely-virtual object in the valueShape of a durable collection. closes #7321
Check that the refcounts are maintained correctly
warner
force-pushed
the
7321-refcount-keyshape-vrefs
branch
from
db996d0 to
5af1b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collectionManager: refcount remotables in keyShape/valueShape
The collection schema (keyShape/valueShape) can refer to specific
Remotable instances (e.g. Presence, or a durable object), rather than
defining a constraint to be a whole category of objects. The
collection schema metadata is thus a form of write-once state storage,
like a tiny virtual object.
Previously, defineKind failed to increment the refcount on the
objects' vrefs, so when the collection falls out of memory, the object
might be deleted, and then we would be unable to revive the constraint
when loading the schema back in later.
This changes the code to increment the refcounts of the vrefs in
keyShape and valueShape when the collection is created, and decrement
them when the collection is deleted. It handles ephemeral Remotables,
as well as virtual/durable object Representatives. For durable
collections, it also enforces the same
isDurablecheck on the schemaas it would on keys and values of the collection itself, so you cannot
use a
Far()or a merely-virtual object in the valueShape of adurable collection.
closes #7321