Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: specify name for identifier #7288

Merged
merged 1 commit into from
Mar 31, 2023
Merged

lint: specify name for identifier #7288

merged 1 commit into from
Mar 31, 2023

Conversation

arirubinstein
Copy link
Contributor

@arirubinstein arirubinstein commented Mar 31, 2023 •
edited
Loading

refs: #7283

Fixes the Identifier to query the name, and the TemplateElement to query correctly

@arirubinstein arirubinstein requested a review from turadg March 31, 2023 01:20
turadg
turadg approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I don't know the symptoms that this is fixing but I'll assume that whatever was observed has been verified to be fixed

@arirubinstein arirubinstein added the automerge:rebase Automatically rebase updates, then merge label Mar 31, 2023
@mergify mergify bot merged commit f4de2ed into master Mar 31, 2023
@mergify mergify bot deleted the ari/lintfixup branch March 31, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arirubinstein @turadg