Various swing-store fixes #7259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
approved these changes
Mar 28, 2023
|
@warner this touches some types you were having trouble with, I just want to make sure this won't break any changes you may have in flight. |
warner
approved these changes
Mar 29, 2023
|
@Mergifyio unqueue |
☑️ The pull request is not queued |
mhofman
force-pushed
the
mhofman/swing-store-fixes
branch
from
bb070ce to
231b8c5
Compare
mhofman
force-pushed
the
mhofman/swing-store-fixes
branch
from
231b8c5 to
b1343b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #7026
Description
This is a grab bag of swing-store changes and fixes. Some are required for the state-sync PR and extracted from it (#7225), some are follow up from #7026.
Most commits are independent, and best reviewed separately.
Security Considerations
This adds a few more consistency checks on the swing-store tables, ensuring that the data doesn't get in an unexpected state due to bugs or bad manipulations of the raw DB.
Scaling Considerations
None
Documentation Considerations
Some type changes are there to be more explicit about the expected usage and values.
Testing Considerations
Manually testing against state-sync branch