fix(action): handle missing Collateral allocation

[dckc]

refs: #6930

Description

Fix code that assumed getCurrentAllocation() would include an amount in the .Collateral property.
Designed in collaboration with @Chris-Hibbert

Testing Considerations

probably merits a regression test.

[datadog-full-agoric]

Datadog Report

Branch report: dc-auction-fix1
Commit report: 93caaf3

✅ agoric-sdk: 0 Failed, 0 New Flaky, 3594 Passed, 55 Skipped, 21m 49.15s Wall Time

[turadg]

Change LGTM.

probably merits a regression test.

Agree. More general fix could be for "getCurrentAllocation" to be more honest about the possible return values so that this would have been caught statically. Fine my be to make that a ticket for the queue since it will probably require many assertions.

[Chris-Hibbert]

Add

  const seat3 = await driver.bidForCollateralSeat(
    currency.make(210n),
    collateral.make(200n),
  );

after seat2 in 'multiple bidders at one auction step' in test-auctionContract.

[turadg]

More general fix could be for "getCurrentAllocation" to be more honest about the possible return values so that this would have been caught statically. Fine my be to make that a ticket for the queue since it will probably require many assertions.

I tried this and it does spawn many errors. Filed away as #7198