feat(vaults)!: vstorage index node for managers #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
turadg
force-pushed
the
6111-rationalize-paths
branch
from
72bcd8d to
b3c373c
Compare
This was referenced Apr 29, 2023
This breaks clients expecting managerN to be a child of vaultFactory
turadg
force-pushed
the
6111-rationalize-paths
branch
from
b3c373c to
6e1f851
Compare
|
Oh yea this also breaks https://github.com/Agoric/dapp-inter/blob/main/src/service/vaults.ts#L256 and a few other lines. I'll make a PR and test locally |
samsiegart
approved these changes
May 2, 2023
turadg
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6111
Description
One important piece of #6111 to get out in the Vaults release: put the indexed vault managers under a
managerskey. Makes the managers list queriable by enumerating children of the node. (Without this to enumerate would require looking at all children ofvaultFactoryand filtering by string pattern.)This breaks clients expecting managerN to be a child of vaultFactory. The one client using it,
Security Considerations
--
Scaling Considerations
--
Documentation Considerations
Updated the README
Testing Considerations
CI and updating dapps