misc refactorings #7131
Merged
misc refactorings #7131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
erights
approved these changes
Mar 8, 2023
| @@ -26,6 +26,7 @@ import { makeAuctionBook } from './auctionBook.js'; | |||
| import { AuctionState } from './util.js'; | |||
| import { makeScheduler } from './scheduler.js'; | |||
| import { auctioneerParamTypes } from './params.js'; | |||
| import { appendToStoredArray } from '@agoric/store/src/stores/store-utils.js'; | |||
There was a problem hiding this comment.
How about we make it a direct export from @agoric/store and avoid the deep import?
There was a problem hiding this comment.
Probably better but not worth another CI spin imo. I expect we'll clean up deep imports after or as part of refactoring the repo.
| @@ -373,7 +373,7 @@ export const parseRatio = ( | |||
| throw Fail`Invalid numeric data: ${numeric}`; | |||
| } | |||
|
|
|||
| const [whole, part = ''] = [match[1], match[2]]; | |||
| const [_, whole, part = ''] = match; | |||
Chris-Hibbert
approved these changes
Mar 8, 2023
turadg
added
the
automerge:no-update
turadg
force-pushed
the
ta/appendToStoredArray
branch
from
b35afb3 to
d792b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some refactors that had come up
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations