fix(cosmic-swingset): Provide blockTime to bootstrap #7125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7124
Description
call
timer.poll()
before running the bootstrap code.The wiring of the device is performed synchronously when the devices are built, so there the implementation won't throw.
The implementation of
poll
should only access its own state since no callbacks would be registered yet, which seems safe to do before any bootstrap code has actually run. I have not fully audited the device code however to check this, just a cursory look.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Tested locally with the loadgen to make sure this change actually solves #7124 and that no timer related errors occur.