Fix ag-solo kernel reentrancy and fake-chain non-determinism #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
requested changes
Mar 17, 2020
FUDCo
approved these changes
Mar 17, 2020
Propagate inboundHandler errors better. Prevent asynchronous rejection errors.
michaelfig
force-pushed
the
mfig/better-errors-and-sync
branch
from
f82558d to
c70b8a1
Compare
FUDCo
reviewed
Mar 17, 2020
michaelfig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268
This PR fixes a longstanding problem with anacrophobia in an
ag-solothat had been subjected to HTTP calls and then restarted. It also fixes some other sources of nondeterminism in theag-soloreplay mechanism due to problems in the timer device integration.Propagate inboundHandler errors better. Prevent asynchronous rejection errors. Synchronise the inbound messages calls.