vaultFactory proposal shapes #7094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Mar 1, 2023
packages/ERTP/src/paymentLedger.js
Outdated
| /** | ||
| * @param {Brand} brand | ||
| * @param {AssetKind} assetKind | ||
| * @param {Matcher} elementShape |
There was a problem hiding this comment.
Suggested change
| * @param {Matcher} elementShape | |
| * @param {Pattern} elementShape |
For example, harden({ x: M.bigint() }) is a Pattern but not a Matcher, whereas M.bigint() is both a Pattern and a Matcher.
turadg
force-pushed
the
ta/vaultFactory-proposal-shapes
branch
from
0a5c7de to
3ea332d
Compare
turadg
added
automerge:no-update
|
Can this wait until after #7047? |
turadg
removed
the
automerge:no-update
Closed
turadg
force-pushed
the
ta/vaultFactory-proposal-shapes
branch
from
3ea332d to
dfbf8c5
Compare
Datadog ReportBranch report: ✅ |
turadg
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #7041
Description
assertProposalShapehas deprecated and the replacement is to use a new argument tomakeInvitations, which provides better protection for contracts against malformed offers. When an offer's proposal violates the contract's required proposalShape pattern, it is rejected in Zoe and the contract never even sees the malformed offer.This does that for vaultFactory. While touching these it also specifies the brand in the shape guard. To do this without an
E(brand).getAmountShape()remote call it uses a new helpermakeNatAmountShape()that can be safely used in Inter Protocol because the amount kinds are known. I put it in inter-protocol's contractSupport so not endorse the usage elsewhere.Security Considerations
Improves guarding by testing earlier and including the brand.
Scaling Considerations
The shape is now constructed on each makeInvitation instead of once at module scope. If this is a problem it could be memoized.
Documentation Considerations
--
Testing Considerations
CI