fix: multiple deposits of unknown brand #7027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Feb 17, 2023
| @@ -374,11 +374,13 @@ export const prepareSmartWallet = (baggage, shared) => { | |||
| return E(invitationPurse).deposit(payment); | |||
| } | |||
|
|
|||
| // When there is no purse, queue the payment | |||
| // When there is no purse, save the payment into a queue. | |||
| // It's not yet ever read but a future version of the contract can | |||
There was a problem hiding this comment.
Interesting... so we don't yet trigger deposits when new issuers come along, but we support upgrade to a wallet that does.
Hm... is there a way for somebody to send an ERTP payment with a brand not known to the vbank? I can't think of one. I was thinking we might owe an issue for the case of newly-approved tokens, but I think we're internally consistent as-is.
| if (queues.has(brand)) { | ||
| queues.get(brand).push(payment); | ||
| const extant = queues.get(brand); | ||
| queues.set(brand, harden([...extant, payment])); |
turadg
added
automerge:no-update
turadg
force-pushed
the
6961-save-unknown-payments
branch
from
8bdc1a5 to
45bff83
Compare
dckc
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6961
Description
Makes a new array instead of try to push to the hardened one. Also improved docs on how unknown brand deposits are handled.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Failing test now passing.