-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xsnap)!: Update Moddable SDK and xsnap-native #6920
Conversation
e934cc7
to
2e5a120
Compare
Apparently something broke, and I'm surprised the testing I didn't uncover these issues. |
I skimmed the Not sure what's going on with the test (slogSender something?), but assuming it's something trivial, I think the PR is good to go once it works again. (hm, I did notice some more file descriptors referenced in the xsnap code.. but I think that only happens if you ask for instrumentation/debugging to be turned on. There's a remote chance that the extra FDs used for the slogsender pipe are getting inherited by the xsnap child process and colliding with something it wants to use for debugging. That would qualify as a non-trivial problem :) |
Oh that's an excellent idea. When I ran my tests I hadn't had time to fully understand the instrumentation changes, so I had ommitted that commit entirely. As described at agoric-labs/xsnap-pub#34, I didn't feel fully confident in them so I disabled them using the build option, thinking the new select would result in a no-op because we're not using these FDs, but maybe that isn't the case. I'll do more testing. |
Moddable SDK 3.7.0 xsnap-native: - handle profiler and instrumentation changes (disabled) - updated promise queue behavior
2e5a120
to
4f7703b
Compare
I figured it out: faulty disablement of the new intrument logic, and that code hangs if the fd doesn't exist. More info at agoric-labs/xsnap-pub#34 (comment) |
@warner, all checks are green, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recent changes to xsnap/ look good, I think we're go
closes: #6759
supersedes: #6011 #6768
Description
Updates our old fork of the Moddable SDK to the official 3.7.0 version
Updates xsnap-native with the following changes (details at agoric-labs/xsnap-pub#34):
Security Considerations
This update contains a lot of bug fixes in XS found by fuzzing tools. This should be a strict improvement.
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Followed the following process (now described in #6929)
mhofman/pismo-with-replay-tools-improvements-updated-xs~1
mhofman/pismo-with-replay-tools-improvements-updated-xs
(PR #6931 for chain transcript replay tool against master)