Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anachrophobia should crash hard #666

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

michaelfig
Copy link
Member

Closes #68

Now the SwingSet kernel will not proceed if there is anachrophobia (replaying the transcript produced different results).

The cases that cause this still need to be diagnosed, but at least we won't have easily-overlooked failures.

Closes #68

Now the SwingSet kernel will not proceed if there is anachrophobia.
The cases that cause this still need to be diagnosed, but at least
we won't have easily-overlooked failures.
@michaelfig michaelfig added the SwingSet package: SwingSet label Mar 6, 2020
@michaelfig michaelfig requested review from warner and FUDCo March 6, 2020 19:08
@michaelfig michaelfig changed the title fix: anachrophobia should crash hard Anachrophobia should crash hard Mar 6, 2020
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelfig michaelfig merged commit c80a299 into master Mar 6, 2020
@michaelfig michaelfig deleted the 68-anachrophobia-should-crash branch March 6, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SwingSet package: SwingSet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"anachrophobia" replay error on restart
2 participants