fix: test-rankOrder works on ava 3 or 4 #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-test-rankOrder-works-ava-3or4
branch
2 times, most recently
from
2fc05a1 to
19d23d2
Compare
erights
force-pushed
the
markm-test-rankOrder-works-ava-3or4
branch
from
19d23d2 to
f268899
Compare
turadg
pushed a commit
that referenced
this pull request
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endojs/endo#1260 would move test-rankOrder to the endo repository, which is currently on ava 3, so the test in that PR has been changed to work on ava 3 or 4. The change needed IMO was also a net improvement in code quality, so at least in this case there's no cost. This PR ports that back to test-rankOrder.js in agoric-sdk to minimize the maintenance hazard while this file exists in both places.
See also
endojs/endo#1291
#6296