-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SwingSet): evictAfterSnapshot option for periodic eviction of all vats #5929
Conversation
b52b35b
to
0aff12c
Compare
@arirubinstein @warner maybe we should land this after all, until we have a better idea? |
Let's look at the slogfile timing and get a sense for how long it takes to evict the worker (and how long it takes to load it back in again later).. that should help us make a decision. |
Let's add Although .. hang on, the second worker startup should be happening from the snapshot, so why is it invoking |
This lets us check whether "turn it off and turn it on again" affects performance trends.
- test 'static vats are unmetered on XS' with both true and false
accc610
to
214b86f
Compare
overtaken by #5987 |
Add a switch in case "turn it off and turn it on again" helps manage vat worker RAM usage.
refs: #5910
Documentation Considerations
$EVICT_AFTER_SNAPSHOT
environment variable is documented.Testing Considerations
unit tests updated
passes a smoke test: