fix: apparent error charging interest during liquidation #5689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no ticket, discovered while working on #5558
Description
chargeAllVaults
when done callsreschedulePriceCheck
. If liquidation is in progress then thehighestRatio()
vault has no collateral allocated because it's in the seat for the liquidation trade. This was resulting in this error logged:This moves the query for
highestRatio()
to lower inreschedulePriceCheck
so it's after the existing returns.It also renames
liquidationInProgress
flag to distinguish from a particular vault being liquidated. The flag just means that the generator is being consumed.Finally, it cleans up 633ee70 because that new name wasn't entirely accurate, and reduces IO by passing the new higher highest ratio in the callback.
Security Considerations
--
Documentation Considerations
--
Testing Considerations
No tests affected. Errors in chargeInterest are intentionally handled only as logging because we don't (yet) have a way to signal problems in recurring calls. Also this PR doesn't actually change the behavior.