fix: make eslint shut up about unhandled promises #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
approved these changes
Jun 10, 2022
| @@ -508,7 +508,7 @@ export function makeNetworkProtocol(protocolHandler) { | |||
| }); | |||
|
|
|||
| // Wire up the local protocol to the handler. | |||
| E(protocolHandler).onCreate(protocolImpl, protocolHandler); | |||
| void E(protocolHandler).onCreate(protocolImpl, protocolHandler); | |||
There was a problem hiding this comment.
@michaelfig is this right? Do we need to be more careful with a rejection from onCreate ?
There was a problem hiding this comment.
No, making it an unhandled rejection is perfectly fine.
| @@ -205,7 +205,7 @@ export function makePluginManager(pluginDevice, { D, ...vatPowers }) { | |||
| }); | |||
|
|
|||
| // Declare the first reset. | |||
| E(resetter).onReset(Promise.resolve(false)); | |||
| void E(resetter).onReset(Promise.resolve(false)); | |||
michaelfig
force-pushed
the
5535-linty-fresh-promises
branch
from
81612f8 to
16a0589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5535