feat(swingset): add vatAdminService.getBundleIDByName() #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
reviewed
May 14, 2022
| if (method === 'getBundleIDByName') { | ||
| const args = unserialize(argsCapdata); | ||
| const [name] = args; | ||
| assert.typeof(name, 'string', `getBundleIDByName() name`); |
There was a problem hiding this comment.
I take it kernel code doesn't use `X`...` for error message details?
There was a problem hiding this comment.
I generally find X/details to impede debugging, and I value that more than the possible information leakage when caller A calls B, B does getBundleIDByName(secretName), and A catches the error to learn the name (none of which matters on a transparent chain anyways).
At some point we should probably have a collective discussion on the utility of that argument censorship (and more generally to find a coding style that we're all comfortable with and make the kernel use it, since we in kernel land have not been following all parts of the general agoric-sdk style, i.e. named => functions).
This API takes the name of a statically-configured bundle (i.e. a property name of `config.bundles`) and returns its BundleID (a hash string). This can be used later in `E(zoe).installBundleID(id)`. refs #4374 , specifically this API will allow bootstrap to deal with bundleIDs and bundleCaps rather than bundles.
warner
force-pushed
the
4374-getbundleidbyname
branch
from
00c5ca3 to
1ab58fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API takes the name of a statically-configured bundle (i.e. a
property name of
config.bundles) and returns its BundleID (a hashstring). This can be used later in
E(zoe).installBundleID(id).refs #4374 , specifically this API will allow bootstrap to deal with
bundleIDs and bundleCaps rather than bundles.