fix(swingset): move upgrade() vatParameters into options bag #5365
Conversation
| @@ -98,7 +98,13 @@ export function buildRootObject(vatPowers) { | |||
| done() { | |||
| return doneP; | |||
| }, | |||
| upgrade(bundlecap, vatParameters) { | |||
| upgrade(bundlecap, options) { | |||
There was a problem hiding this comment.
options should default to {}, so existing code that isn't using it don't need to change.
There was a problem hiding this comment.
Hmm. On second thought I'm not sure how downstream code will handle a missing vatParameters parameter. I had been thinking you could get away with leaving it off if you didn't have any parameters, and maybe you could have. If so, you should still be able to do that. If not, maybe you should.
There was a problem hiding this comment.
Good catch!
I guess omitting vatParameters in the upgrade should get you the same value as you'd get omitting it in the original createVat. That ought to be undefined, but now that I'm looking at the code, I'm not sure that's what happens. I'll add a test.
warner
force-pushed
the
5345-upgrade-options
branch
from
62e9bde to
0725890
Compare
warner
force-pushed
the
5345-upgrade-options
branch
from
0725890 to
d3e2641
Compare
Previously, the parent vat did `E(adminFacet).upgrade(vatParameters)`
Now it does `E(adminFacet).upgrade(bundleCap, { vatParameters })`
This matches the way `vatParameters` are passed to the original
`createVat()` call.
All other options are rejected. The `options` argument itself is
optional.
This changes the `adminFacet` API, but internally continues to send
`vatParameters` in their own argument to the underlying device
nodes. If/when we send actual options, we'll need to decide whether to
change the shape of the device node API by converting `vatParameters`
into `options`, or just add additional arguments.
closes #5345
warner
force-pushed
the
5345-upgrade-options
branch
from
d3e2641 to
d26b872
Compare
Previously, the parent vat did
E(adminFacet).upgrade(vatParameters)Now it does
E(adminFacet).upgrade(bundleCap, { vatParameters })This matches the way
vatParametersare passed to the originalcreateVat()call.All other options are rejected.
This changes the
adminFacetAPI, but internally continues to sendvatParametersin their own argument to the underlying devicenodes. If/when we send actual options, we'll need to decide whether to
change the shape of the device node API by converting
vatParametersinto
options, or just add additional arguments.closes #5345