Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(swingset): use test.serial on GC-sensitive test #4644

Merged
merged 1 commit into from
Feb 23, 2022
+7 −2
Merged

test(swingset): use test.serial on GC-sensitive test #4644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/SwingSet/test/test-activityhash-vs-start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ import { buildTimer } from '../src/devices/timer.js';
const TimerSrc = new URL('../src/devices/timer-src.js', import.meta.url)
.pathname;

test('restarting kernel does not change activityhash', async t => {
// all tests that are sensitive to GC timing (which means anything that
// exercises transcript replay or looks at activityHash) need to use
// test.serial or config.defaultManagerType='xsnap', until we figure out why
// gcAndFinalize sometimes doesn't work (details in #3240 and #4617)

test.serial('restarting kernel does not change activityhash', async t => {
const sourceSpec = new URL('vat-empty-setup.js', import.meta.url).pathname;
const config = {
bootstrap: 'bootstrap',
Expand Down Expand Up @@ -87,7 +92,7 @@ test('restarting kernel does not change activityhash', async t => {
t.is(c1ah, c2ah);
});

test('comms initialize is deterministic', async t => {
test.serial('comms initialize is deterministic', async t => {
// bug #3726: comms was calling vatstoreGet('initialize') and
// vatstoreSet('meta.o+0') during the first message after process restart,
// which makes it a nondeterministic function of the input events.
Expand Down